PCP-4205: 🐛 fix: separate control plane logging and vpc config updates #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please help add description to PR |
pavansokkenagaraj
force-pushed
the
pa1/pcp-4205
branch
from
e5f6595 to
3bb68dd
Compare
AmitSahastra
approved these changes
Mar 28, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AmitSahastra, pavansokkenagaraj The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AmitSahastra
pushed a commit
that referenced
this pull request
May 2, 2025
#954) * fix: separate control plane logging and vpc config updates * fix: set PublicCIDRs to [] when private only EP
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref:
kubernetes-sigs#3553 (comment)
kubernetes-sigs#4918 (comment)
kubernetes-sigs#5441
kubernetes-sigs#5442
What type of PR is this?
/kind bug
What this PR does / why we need it:
What this PR does / why we need it:
EKS does not allow for both a VPC config update and a logging update in the same API call. If both of these changes are applied to the spec at once, then the AWSManagedControlPlane will fail to reconcile.
Addresses the restriction in the EKS API by separating logging and vpc config updates into two separate steps.
Try updating EKS cluster's logging config and vpc config at a time.
EKS doesn't allow multiple types of updates at once and this would fail
aws eks update-cluster-config --name --resources-vpc-config '{"endpointPrivateAccess":true}' --logging '{"clusterLogging":[{"types":["authenticator"],"enabled":true}]}'
An error occurred (InvalidParameterException) when calling the UpdateClusterConfig operation: Only one type of update can be allowed.
Observed when CAPA reconciles private endpoints when EKS deployed with endpoint access: private
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist:
Release note: